saihemanth-cloudera commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1154436457
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2070,18 +2096,30 @@ struct CreateDatabaseRequest {
8: optional string catalogName,
9: optional i32 createTime,
10: optional string managedLocationUri,
- 11: optional string type,
- 12: optional string dataConnectorName
+ 11: optional DatabaseType type,
+ 12: optional string dataConnectorName,
+ 13: optional string remote_dbname
}
struct CreateDataConnectorRequest {
- 1: DataConnector connector
+ 1: required DataConnector connector
}
struct GetDataConnectorRequest {
1: required string connectorName
}
+struct AlterDataConnectorRequest {
+ 1: required string connectorName,
+ 2: required DataConnector newConnector
+}
+
+struct DropDataConnectorRequest {
+ 1: required string connectorName,
+ 2: optional bool ifNotExists,
+ 3: optional bool checkReferences
Review Comment:
Here the change is about creating a request-based API for the already
existing API (which takes in all the above 3 parameters).
Currently, we don't use this flag. Yeah, your concern is genuine in the
future when we implement this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
