dengzhhu653 commented on code in PR #5206: URL: https://github.com/apache/hive/pull/5206#discussion_r1598479972
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ########## @@ -3960,9 +3926,57 @@ public List<Partition> listPartitionsPsWithAuth(String catName, String db_name, return partitions; } + private Integer getNumPartitionsViaOrmPs(Table table, List<String> partVals) throws MetaException { + // size is known since it contains dbName, catName, tblName and partialRegex pattern + Map<String, String> params = new HashMap<>(4); Review Comment: if this method isn't reused elsewhere, I would prefer put this codes into `getJdoResult`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org