henrib commented on code in PR #5145:
URL: https://github.com/apache/hive/pull/5145#discussion_r1848840986
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -732,10 +756,26 @@ public static void startMetaStore(int port,
HadoopThriftAuthBridge bridge,
}
// optionally create and start the property server and servlet
propertyServer = PropertyServlet.startServer(conf);
+ // optionally create and start the Iceberg REST server and servlet
+ icebergServer = startIcebergCatalog(conf);
Review Comment:
It would make sense to host only one Jetty and create connectors/servlets
per feature. Albeit this requires even more changes (and some logic to start
the server if any of the feature servlets is required) that are not required
for the task at hand. This seems like a 'lateral' move wrt handing Iceberg
Catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
