zratkai commented on code in PR #5145:
URL: https://github.com/apache/hive/pull/5145#discussion_r1881629966
##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -32,6 +32,21 @@
<groupId>org.apache.hive</groupId>
<artifactId>hive-iceberg-shading</artifactId>
</dependency>
+ <!-- Intellij dislikes shaded Iceberg: uncomment the following block helps
when coding/debugging -->
+ <!--
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-api</artifactId>
+ <version>${iceberg.version}</version>
+ <optional>true</optional>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+ <artifactId>iceberg-core</artifactId>
+ <version>${iceberg.version}</version>
+ <optional>true</optional>
+ </dependency>
+ -->
Review Comment:
It is never a recommended to store "garbage" and uncommented code in a
repository. This is an antipattern. You can save it to yourself in your local
repo and use it when needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
