zratkai commented on code in PR #5145:
URL: https://github.com/apache/hive/pull/5145#discussion_r1881626315
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2235,6 +2235,10 @@ public static enum ConfVars {
HIVE_ICEBERG_ALLOW_DATAFILES_IN_TABLE_LOCATION_ONLY("hive.iceberg.allow.datafiles.in.table.location.only",
false,
"If this is set to true, then all the data files being read should be
withing the table location"),
+ HIVE_ICEBERG_CATALOG_ACTOR_CLASS("hive.iceberg.catalog.actor.class",
"org.apache.iceberg.rest.HMSCatalogActor",
+ "Catalog actor implementation class. Default value is an embedded
(no-thrift) catalog actor." +
+ "For a thrift-based single-tenant actor, use
\"org.apache.iceberg.hive.HiveCatalogActor\".."),
+
Review Comment:
I could not easily distinguish between EmbeddedCatalogActor and
ThriftCatalogActor.
More meaningful names are the best choise. Since this is an Iceberg
extension IcebergRestCatalogActor and HiveTriftCatalogActor sound good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
