henrib commented on code in PR #5145: URL: https://github.com/apache/hive/pull/5145#discussion_r1852633590
########## iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveActor.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.hive; + +import java.util.List; +import java.util.Map; +import org.apache.hadoop.hive.metastore.api.Database; +import org.apache.hadoop.hive.metastore.api.LockRequest; +import org.apache.hadoop.hive.metastore.api.LockResponse; +import org.apache.hadoop.hive.metastore.api.ShowLocksRequest; +import org.apache.hadoop.hive.metastore.api.ShowLocksResponse; +import org.apache.hadoop.hive.metastore.api.Table; +import org.apache.iceberg.TableMetadata; +import org.apache.iceberg.catalog.Namespace; +import org.apache.thrift.TException; + +/** + * Acts as the Hive client for the HiveCatalog benefit. + */ +public interface HiveActor { Review Comment: Finally got what you said with some external help ;-) : if we are to set the THRIFT_URIS to blank in the config, the client created (HiveMetaStoreClient actor) checks MetastoreConf.isEmbeddedMetaStore(...) and calls callEmbeddedMetastore(...) which is not based on a Thrift client but a genuine IHMSHandler. By deriving HiveCatalog and overriding the method createPool() with a config modified to blank THRIFT_URIS, we now have a way to create embedded HiveCatalog. I wish I learnt that earlier... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
