dengzhhu653 commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948721502
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -55,6 +56,7 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
Properties properties = replacePrefix(
DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI));
long connectionTimeout = hdpConfig.getLong(CONNECTION_TIMEOUT_PROPERTY,
30000L);
+ long maxLifetime = hdpConfig.getLong(MAX_LIFETIME, 3600000L);
Review Comment:
what if the max lifetime is equal to the leak detection, will the rule for
leak detection not take effect as the max lifetime takes first?
To me, the default of LEAK_DETECTION_THRESHOLD is too long, we can turn down
this value, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
