zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1948856692
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -55,6 +56,7 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
Properties properties = replacePrefix(
DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI));
long connectionTimeout = hdpConfig.getLong(CONNECTION_TIMEOUT_PROPERTY,
30000L);
+ long maxLifetime = hdpConfig.getLong(MAX_LIFETIME, 3600000L);
Review Comment:
If we add MAX_LIFETIME then we are adding a new config toggle that was not
available before. I am not against doing it but it seems like independent of
the main purpose of the PR.
Regarding the value of the threshold I agree with @dengzhhu653 that 1h is
probably too long and it makes sense to lower it. In fact, since it is a debug
property maybe we should keep it disabled by default (i.e., `0`). I don't know
how easy it is to pick a value that is useful in every use-case of the
metastore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
