okumin commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1950229849
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -55,6 +56,7 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
Properties properties = replacePrefix(
DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI));
long connectionTimeout = hdpConfig.getLong(CONNECTION_TIMEOUT_PROPERTY,
30000L);
+ long maxLifetime = hdpConfig.getLong(MAX_LIFETIME, 3600000L);
Review Comment:
@dengzhhu653 @zabetak
> To me, the default of LEAK_DETECTION_THRESHOLD is too long, we can turn
down this value, what do you think?
> Regarding the value of the threshold I agree with @dengzhhu653 that 1h is
probably too long and it makes sense to lower it. In fact, since it is a debug
property maybe we should keep it disabled by default (i.e., 0). I don't know
how easy it is to pick a value that is useful in every use-case of the
metastore.
It makes sense to lower the threshold.
I have no strong opinion about 0 vs moderate minutes. I'd keep it to be
positive based on the report of HIVE-25482, as the parameter is not harmless
anyway. 0 is also an option as we don't know a specific case where HIVE-25482
is needed.
The updated revision configures 10 minutes, cleaning up the class leveraging
`getPrefixedProperties`. 0 seconds vs 10 minutes vs else could be still
controversial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
