zabetak commented on code in PR #5639:
URL: https://github.com/apache/hive/pull/5639#discussion_r1950450432
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -79,13 +78,10 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
// so that the connection pool can retire the idle connection aggressively,
// this will make Metastore more scalable especially if there is a leader
in the warehouse.
if ("mutex".equals(poolName)) {
- int minimumIdle = Integer.valueOf(hdpConfig.get(HIKARI + ".minimumIdle",
"2"));
Review Comment:
I just seen that we pass the value to a primitive int so calling `valueOf`
is completely useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
