abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2217777623
##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -609,47 +610,32 @@ public static Completer[] getCommandCompleter() {
candidateStrings.add(s.toLowerCase());
}
- StringsCompleter strCompleter = new StringsCompleter(candidateStrings);
-
- // Because we use parentheses in addition to whitespace
- // as a keyword delimiter, we need to define a new ArgumentDelimiter
- // that recognizes parenthesis as a delimiter.
Review Comment:
similarly to the beeline case, this is now handled in DefaultParser which is
implemented as
```
static DefaultParser getDefaultParser() {
return new DefaultParser() {
@Override
public boolean isDelimiterChar(CharSequence buffer, int pos) {
// Because we use parentheses in addition to whitespace
// as a keyword delimiter, we need to define a new ArgumentDelimiter
// that recognizes parenthesis as a delimiter.
final char c = buffer.charAt(pos);
return (Character.isWhitespace(c) || c == '(' || c == ')' ||
c == '[' || c == ']');
}
};
}
```
in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
