abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2217774650
##########
beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java:
##########
@@ -80,7 +81,7 @@ public void testCommentStripping() {
@Test
public void testSetPromptValue() {
- verifyCMD("set hive.cli.prompt=MYCLI;SHOW\nTABLES;", "MYCLI> ", err, null,
+ verifyCMD("set hive.cli.prompt=MYCLI;SHOW\nTABLES;\n", "MYCLI> ", err,
null,
Review Comment:
good catch, it's definitely something I wanted to get back to :) it's turned
out that I haven't handled the EndOfLineException properly, which is currently
being fixed, making all these extra line feeds unnecessary (hence properly
getting back to the old Jline2 behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
