abstractdog commented on code in PR #5838:
URL: https://github.com/apache/hive/pull/5838#discussion_r2218433924
##########
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java:
##########
@@ -175,13 +173,40 @@ static String testCommandLineScript(List<String> argList,
InputStream inputStrea
throw new RuntimeException("Unexpected outstream type " + streamType);
}
String[] args = argList.toArray(new String[argList.size()]);
- beeLine.begin(args, inputStream);
+ beeLine.begin(args, null);
beeLine.close();
beelineOutputStream.close();
String output = os.toString("UTF8");
return output;
}
+ /*
+ * Creates a BeeLineDummyTerminalFromFile instance that skips the main
execution code path
+ * if an init script has already run. Since this unit test class executes
scripts in init (-i) or file (-f) mode,
+ * we can avoid using waiting hacks and simply return from execute() with
the original init result.
+ */
+ private static BeeLineDummyTerminalFromFile getBeeLineDummyTerminal() {
Review Comment:
it's because of the refactor that came along with the upgrade
thanks for pointing this out, I'm now rewriting the test classes to become
simpler is possible
I'll let you know when all the comments are addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
