1fanwang commented on PR #6454:
URL: https://github.com/apache/hive/pull/6454#issuecomment-4346072129

   Root cause: `MetastoreConf.WAREHOUSE_EXTERNAL` and `THRIFT_URIS` default to 
`""` (not null), so the `containsKey` checks in `HiveCatalog.initialize` passed 
and `stripTrailingSlash("")` tripped. Mirrored `HMSCatalogFactory`'s 
skip-if-unset pattern (extended to empty) in `IcebergSummaryHandler`, and 
switched the remaining `warehouse`/`uri` literals to 
`CatalogProperties.WAREHOUSE_LOCATION` / `CatalogProperties.URI` per the 
line-66 comment. Pushed in bb2f581.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to