1fanwang commented on code in PR #6454:
URL: https://github.com/apache/hive/pull/6454#discussion_r3163467576


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/metasummary/IcebergSummaryHandler.java:
##########
@@ -64,7 +64,7 @@ public void initialize(String catalogName, boolean 
jsonFormat, MetaSummarySchema
     LOG.info("Initializing iceberg summary handler with warehouse:{},external 
warehouse:{},uris:{}",
         mgdWarehouse, extWarehouse, uris);
     propertiesMap.put("warehouse", mgdWarehouse);

Review Comment:
   Done in bb2f581 — switched the propertiesMap keys to 
`CatalogProperties.WAREHOUSE_LOCATION` / `CatalogProperties.URI` and the new 
`HiveCatalog.EXTERNAL_WAREHOUSE_LOCATION`, matching the literal-removal call in 
HMSCatalogFactory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to