deniskuzZ commented on code in PR #6454:
URL: https://github.com/apache/hive/pull/6454#discussion_r3166680362
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -72,22 +72,20 @@ private Catalog createCatalog() {
final String configUri = MetastoreConf.getVar(configuration,
MetastoreConf.ConfVars.THRIFT_URIS);
// Clear THRIFT_URIS so HiveCatalog doesn't accidentally use Thrift
connection
// when REST Catalog is embedded in HMS (same JVM). HiveCatalog reads from
Configuration
- // as fallback, so clearing it ensures it uses embedded connection when
"uri" is not set.
+ // as fallback, so clearing it ensures it uses embedded connection when
CatalogProperties.URI is not set.
MetastoreConf.setVar(configuration, MetastoreConf.ConfVars.THRIFT_URIS,
"");
- // Only set "uri" property if THRIFT_URIS was configured (standalone mode)
+ // Only set CatalogProperties.URI if THRIFT_URIS was configured
(standalone mode)
// This tells HiveCatalog to use Thrift connection to external HMS
if (configUri != null && !configUri.isEmpty()) {
Review Comment:
@1fanwang should we use !StringUtils.isEmpty here as well? for all 3 configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
