@eht16 commented on this pull request.
> + log "Signing Geany binary files"
+ for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+ for binary_file in $(ls ${binary_file_pattern}); do
+ sign_file ${binary_file}
+ done
+ done
+}
+
+
+convert_text_files_to_crlf() {
+ log "Converting line endings to CRLF in text files"
+ for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+ for text_file in $(ls ${text_file_pattern}); do
+ mime_type=$(file --brief --mime-type ${text_file})
+ case $mime_type in text/*)
+ unix2dos ${text_file}
I don't expect from Geany's build system to know whether it need to convert
text files to the target system's preferences.
IMO this is very Windows specific and basically only necessary to be able to
read our text files with Windows' Notepad which is not able to handle different
line endings.
In Geany, we would need to properly integrate it in Autotools and Meson and
also depend on "unix2dos".
Regarding Git's `core.eol`: I'm not what happens on a native Windows clone but
here we use the already cloned repository from the CI job and even if we would
clone it ourselves, it would be LF as everything in this script is executed on
Linux.
Changing the setting to `crlf` might have other side effects we do not want.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1002525301
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3315/review/1152058...@github.com>
