@kugel- commented on this pull request.
> + log "Signing Geany binary files"
+ for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+ for binary_file in $(ls ${binary_file_pattern}); do
+ sign_file ${binary_file}
+ done
+ done
+}
+
+
+convert_text_files_to_crlf() {
+ log "Converting line endings to CRLF in text files"
+ for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+ for text_file in $(ls ${text_file_pattern}); do
+ mime_type=$(file --brief --mime-type ${text_file})
+ case $mime_type in text/*)
+ unix2dos ${text_file}
Well the CI builds shouldn't have "more features" than normal builds from
source - source code is king!! If a hard dependency in the normal build is not
wanted then there could be an optional dependency that is _coincidentally_ met
by the CI.
I wouldn't want manual git or tarball builds to regress compared to CI builds
(e.g. on Windows 7). Stuff like this is hard to track down even for experienced
contributors.
IMO: Let's open an issue regarding the line ending issue. Then we either deal
with it in the normal build or just live with it as suggested by @elextr . I
can help with meson if that's a problem.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1008746141
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3315/review/1161030...@github.com>
