@elextr commented on this pull request.
> + log "Signing Geany binary files"
+ for binary_file_pattern in ${GEANY_RELEASE_BINARY_PATTERNS[@]}; do
+ for binary_file in $(ls ${binary_file_pattern}); do
+ sign_file ${binary_file}
+ done
+ done
+}
+
+
+convert_text_files_to_crlf() {
+ log "Converting line endings to CRLF in text files"
+ for text_file_pattern in ${GEANY_RELEASE_TEXTFILE_PATTERNS[@]}; do
+ for text_file in $(ls ${text_file_pattern}); do
+ mime_type=$(file --brief --mime-type ${text_file})
+ case $mime_type in text/*)
+ unix2dos ${text_file}
> Windows' Notepad which is not able to handle different line endings.
Works on my windows 11 tablet[^1]. Google says it was fixed in 2018, so any
_supported_ version of Windows should be ok ;-P
> Regarding Git's core.eol: I'm not what happens on a native Windows clone but
> here we use the already cloned repository from the CI job and even if we
> would clone it ourselves
Ok, so its necessary for the CI job, but I was really addressing @kugel-
"Anyone who builds Geany from source on Windows should do this right?" but IIUC
their checkout would do it for them with default git settings. If tarballs are
going to be buildable on windows I guess its needed there as well since the
tarball files are LF endings unless we make a special Windows tarball ... or
just say they are *x or modern Windows only.
> Changing the setting to crlf might have other side effects we do not want.
Yes, IIUC "Bad things" will happen if we merge anything back on Linux with that
setting.
[^1]: No, its a _tablet_ so Geany is no use as I don't develop on it, sorry
can't help with windows builds ;-P
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3315#discussion_r1002602492
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany/pull/3315/review/1152175...@github.com>
