@b4n commented on this pull request.
> static gint glspi_activate(lua_State* L)
{
- gint idx=-1;
- if (lua_gettop(L)>0) {
- if (lua_isnumber(L,1)) {
- idx=(lua_tonumber(L,1));
- if (idx<0) { /* Negative number refers to (absolute)
GtkNotebook index */
- idx=(0-idx)-1;
- if (idx>=gtk_notebook_get_n_pages(NOTEBOOK)) {
idx=-1;}
- } else { /* A positive number refers to the
geany->documents_array index */
- idx=doc_idx_to_tab_idx(idx-1);
+ gint lua_idx = -1;
The scope of `lua_idx` could be reduced, and it probably would make things a
bit more clear (is that used for anything else, and what is that `-1` about
while `-1` is supposed to mean "first tab"?)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1234#pullrequestreview-2708875705
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1234/review/[email protected]>
