b4n left a comment (geany/geany-plugins#1234)

So, the actual functional changes this is supposed to make is replace the buggy 
`doc_idx_to_tab_idx()` with `document_get_notebook_page()`, and returning `idx 
>= 0` instead of `idx > 0`, right?  The rest doesn't seem to try changing much 
to the logic, if I follow.

I don't know the plugin or Lua, but this looks (mostly) fine -- se review 
comments for the more questionable bits.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1234#issuecomment-2746566816
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany-plugins/pull/1234/[email protected]>

Reply via email to