@b4n commented on this pull request.
> static gint glspi_activate(lua_State* L)
{
- gint idx=-1;
- if (lua_gettop(L)>0) {
- if (lua_isnumber(L,1)) {
- idx=(lua_tonumber(L,1));
- if (idx<0) { /* Negative number refers to (absolute)
GtkNotebook index */
- idx=(0-idx)-1;
- if (idx>=gtk_notebook_get_n_pages(NOTEBOOK)) {
idx=-1;}
- } else { /* A positive number refers to the
geany->documents_array index */
- idx=doc_idx_to_tab_idx(idx-1);
+ gint lua_idx = -1;
By reducing scope I just mean moving the variable declaration inside the `if
(lua_isnumber(L, 1)) {}` block where it's used.
As for the initialization, the compiler probably wouldn't complain as the
initial value is never used, but I get that some people like initializing
everything. I just think that `-1` is a poor choice here as IIUC `-1` means
something specific in the code below, while `0` would have been better as it's
the only clearly invalid value for that same code.
On the end it wouldn't change anything on how this behaves, it would just make
the implementation a hair clearer (IMO).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1234#discussion_r2009549480
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1234/review/[email protected]>
