@xiota commented on this pull request.
> static gint glspi_activate(lua_State* L)
{
- gint idx=-1;
- if (lua_gettop(L)>0) {
- if (lua_isnumber(L,1)) {
- idx=(lua_tonumber(L,1));
- if (idx<0) { /* Negative number refers to (absolute)
GtkNotebook index */
- idx=(0-idx)-1;
- if (idx>=gtk_notebook_get_n_pages(NOTEBOOK)) {
idx=-1;}
- } else { /* A positive number refers to the
geany->documents_array index */
- idx=doc_idx_to_tab_idx(idx-1);
+ gint lua_idx = -1;
I wouldn't mind reducing scope, but I've been told changing previously
established functionality should be avoided because it's unknown how many
people might depend on the old behavior.
Indexing of notebook and documents array don't necessarily match, so might have
to split into two separate or create a new lua function to convert between
document and notebook indices.
Regarding the calculation...
-1 ⇒ first tab ⇒ 0
0 - (-1) = 1
1-1 = 0
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1234#discussion_r2009386147
You are receiving this because you are subscribed to this thread.
Message ID: <geany/geany-plugins/pull/1234/review/[email protected]>
