eht16 left a comment (geany/geany#4279)

> But since the menubar is accessible even when hidden now, I think there 
> should be a menu item "View->Show Menubar" to re-show the menubar again as 
> another way to show it for users who use the F10 method. I've just added this 
> feature (not sure how exactly it should behave, right now I hide the `[x] 
> Show Menubar` item when the menubar is shown, but it could also be modified 
> to be always shown when the keybinding is set).

I'd say we should show it always, this advertises the feature a little more and 
gives a quick way to hide the menubar in addition to the keybinding.

> > That would probably be OK as Firefox only shows the menubar when Alt is 
> > released alone.
> 
> But won't you run into that in this case too? For Alt+Key the sequence the 
> user will press/release keys will be:
> 
>     1. Alt press
> 
>     2. Key press
> 
>     3. Key release
> 
>     4. Alt release
> 
> 
> So, IMO, you get a separate alt press or alt release in 1 or 4, respectively 
> (I haven't tested it with GTK though, maybe it behaves some other way).

After having tested this PR, I think neither the Alt nor F10 are very 
necessary. There is a user definable keybinding and there is a message in the 
status window telling the user how they can get the menubar back.
So, for the sake of simplicity, we could also leave it as is.

> > I wouldn't have thought either, but if you like we might be able to squeeze 
> > it if it's ready enough.
> 
> I kind of think it's ready (except for the documentation update Enrico 
> mentioned). So maybe 

Don't feel pushed, I just asked. We don't need to rush it in.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4279#issuecomment-2955065228
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4279/[email protected]>

Reply via email to