b4n left a comment (geany/geany#4279)

@techee regarding Alt behavior: if you test it with Firefox, you see that it 
does the Right Thing™. Your concern is legitimate though, so their 
implementation is probably a bit more complex, like a general keybinding 
handler that verifies that the entire sequence was only alt down/alt up -- and 
indeed I'm not sure it's esay.

> […] I think neither the Alt nor F10 are very necessary. […]

Just on the concept itself: I think F10 *is* necessary.  I think I mentioned it 
before, but <kbd>F10</kbd> is a generic keybinding that triggers the menubar, 
and as such is expected to be available for many keyboard users -- e.g. I know 
many vision-impaired people heavily use it.  So IMO for accessibility purposes 
we ought to keep it working -- regardless of the fact that it's indeed unlikely 
a blind user will care about hiding the menubar anyway, there are plenty other 
keyboard users that might care.

> From UX perspective, it might be confusing that you see the menu item in the 
> View menu when using F10 after it is hidden but the menu item disappear once 
> you activated it to show the menu bar again.

It might, but I agree with @techee that I'd rather start on the safe side an 
avoid risks of inadvertently triggering the menu item.  I'd have to re-check 
the behavior, but maybe indeed the item could be always visible but if and only 
if a keybinding has been set to it, so it's both consistent and safe by default 
as there isn't a default keybinding.  I'll test this again.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4279#issuecomment-2955282939
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4279/[email protected]>

Reply via email to