eht16 left a comment (geany/geany#4279) > > I'd say we should show it always, this advertises the feature a little more > > and gives a quick way to hide the menubar in addition to the keybinding. > > Maybe I wasn't clear enough - it's always shown when the menubar is hidden so > you can always hide it this way. But I'm not sure if it should be shown when > the menubar is displayed - it will lead to the false impression that you can > hide the menubar using it too which is not possible (for "safety" reasons).
Ok. Given that we document this, there is a keybinding, the extra menu item in the context and a message in the status bar, I think this is enough "safety". >From UX perspective, it might be confusing that you see the menu item in the >View menu when using F10 after it is hidden but the menu item disappear once >you activated it to show the menu bar again. In the end, this is a minor detail and should not block this PR. So if you don't agree, it's totally fine for me. > > Don't feel pushed, I just asked. We don't need to rush it in. > > Actually I'd be more than happy to have this in - I just didn't want to > overwhelm the poor reviewers ;-). It seems we are already in the usual "very active short before the release phase" :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4279#issuecomment-2955164911 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/4279/[email protected]>
