techee left a comment (geany/geany#4279)

> I'd say we should show it always, this advertises the feature a little more 
> and gives a quick way to hide the menubar in addition to the keybinding.

Maybe I wasn't clear enough - it's always shown when the menubar is hidden so 
you can always hide it this way. But I'm not sure if it should be shown when 
the menubar is displayed - it will lead to the false impression that you can 
hide the menubar using it too which is not possible (for "safety" reasons).

> After having tested this PR, I think neither the Alt nor F10 are very 
> necessary. There is a user definable keybinding and there is a message in the 
> status window telling the user how they can get the menubar back.
So, for the sake of simplicity, we could also leave it as is.

The F10 key is implemented already. And without it, the `[x] Show Menubar` 
entry discussed above doesn't make sense in the menu as you won't be able to 
access it as the menubar is normally hidden.

> Don't feel pushed, I just asked. We don't need to rush it in.

Actually I'd be more than happy to have this in - I just didn't want to 
overwhelm the poor reviewers ;-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4279#issuecomment-2955110973
You are receiving this because you are subscribed to this thread.

Message ID: <geany/geany/pull/4279/[email protected]>

Reply via email to