ongchi commented on PR #7732:
URL:
https://github.com/apache/arrow-datafusion/pull/7732#issuecomment-1746036365
Several functions added in this PR:
- Functions already listed in documentation but not implemented:
- not
- eq
- not_eq
- gt
- gt_eq
- lt
- lt_eq
- Additional arithmetic functions introduced in this PR:
- add
- sub
- mul
- div
- r#mod
- neg
Few more questions:
- These implementations and tests already exist somewhere. Do these still
have to add test code here?
- `mod` is a reserved keyword in Rust. The reminder function named here to
be able consistant with SQL function naming, but does it ok to `datafusion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
