ongchi commented on PR #7732:
URL:
https://github.com/apache/arrow-datafusion/pull/7732#issuecomment-1746050317
Methods added to `Expr` in this PR:
- Methods already listed in documentation but not implemented:
- bitwise_and
- bitwise_or
- bitwise_xor
- bitwise_shift_left
- bitwise_shift_right
- not
- Additional arithmetic methods introduced in this PR:
- As same as arithmetic functions listed above
I found that there are multiple implementations to do the same thing, e.g.,
bitwise operations on
https://github.com/apache/arrow-datafusion/blob/a64f36d8fbce35cb7146271fb5d9ab98a9f094e6/datafusion/expr/src/expr_fn.rs#L172-L215
and
https://github.com/apache/arrow-datafusion/blob/a64f36d8fbce35cb7146271fb5d9ab98a9f094e6/datafusion/expr/src/operator.rs#L313-L355,
that should/is identical to each other. Do we have to merge these
implementations and place tests in the same place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
