ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1345522939
##########
datafusion/expr/src/expr.rs:
##########
@@ -1032,6 +1033,88 @@ impl Expr {
}
}
+impl Expr {
+ // Operation methods from traits.
+
+ //
+ // Arithmetic operations
+ //
+
+ /// Return `self + other`
+ #[allow(clippy::should_implement_trait)]
Review Comment:
Clippy fires warnings because these methods have same name on trait methods
in `std::ops`. Without these methods, user may require to include specific
traits from `std::ops::*` in their source. Or, should we re-export these traits
in prelude?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
