vibhatha commented on code in PR #43077: URL: https://github.com/apache/arrow/pull/43077#discussion_r1689452848
########## java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java: ########## @@ -60,4 +61,6 @@ public interface VectorVisitor<OUT, IN> { OUT visit(NullVector left, IN value); OUT visit(ExtensionTypeVector<?> left, IN value); + + OUT visit(ListViewVector left, IN value); Review Comment: Oh! What should we do here? The extended classes has its own patterns. Could you explain a bit how we could do a default implementation? (Do we just put an empty method which does nothing?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org