vibhatha commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1689459930
##########
java/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java:
##########
@@ -257,70 +268,6 @@ public void write(${name}Holder holder) {
public void writeNull() {
}
- @Override
Review Comment:
You're correct I have moved some methods unnecessarily. I moved them back.
Now the split take cares of ListView related things in the view class and the
rest as usual in the non view class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
