vibhatha commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1689528752


##########
java/vector/src/main/codegen/templates/PromotableWriter.java:
##########
@@ -526,4 +589,35 @@ public int getValueCapacity() {
   public void close() throws Exception {
     getWriter().close();
   }
+
+  public void setState(State state) {
+    this.state = state;
+  }
+
+  public void setType(MinorType type) {
+    this.type = type;
+  }
+
+  public void setUnionVector(UnionVector unionVector) {
+    this.unionVector = unionVector;
+  }
+
+  public void setVector(ValueVector vector) {
+    this.vector = vector;
+  }
+
+  public void setWriter(FieldWriter writer) {
+    this.writer = writer;
+  }
+
+  public PromotableViewWriter promote() {

Review Comment:
   Right, `toViewWriter()` would be better? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to