ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r586643234
##########
File path: r/configure
##########
@@ -145,7 +150,7 @@ else
# TODO: what about non-bundled deps?
BUNDLED_LIBS=`cd $LIB_DIR && ls *.a`
BUNDLED_LIBS=`echo $BUNDLED_LIBS | sed -E "s/lib(.*)\.a/-l\1/" | sed
-e "s/\\.a lib/ -l/g"`
- PKG_LIBS="-L$(pwd)/$LIB_DIR $PKG_LIBS $BUNDLED_LIBS"
+ PKG_DIRS="-L$(pwd)/$LIB_DIR $PKG_DIRS"
Review comment:
`PKG_DIRS` contains only the `-L` flags, which are directories.
`PKG_LIBS` contain only the `-l` flags, which are package names. Previously
these were combined together in `PKG_LIBS`. I separated them because it makes
the appending/prepending much more straightforward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
