[GitHub] [arrow] ianmcook commented on a change in pull request #9610: ARROW-11735: [R] Allow Parquet and Arrow Dataset to be optional components

Wed, 03 Mar 2021 13:15:34 -0800 


ianmcook commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r586785240



##########
File path: r/configure
##########
@@ -145,7 +150,7 @@ else
         # TODO: what about non-bundled deps?
         BUNDLED_LIBS=`cd $LIB_DIR && ls *.a`
         BUNDLED_LIBS=`echo $BUNDLED_LIBS | sed -E "s/lib(.*)\.a/-l\1/" | sed 
-e "s/\\.a lib/ -l/g"`
-        PKG_LIBS="-L$(pwd)/$LIB_DIR $PKG_LIBS $BUNDLED_LIBS"
+        PKG_DIRS="-L$(pwd)/$LIB_DIR $PKG_DIRS"

Review comment:
       Oh, gotcha. I just went through and checked the control flow more 
carefully, and I agree—`PKG_DIRS` will never be set here. I removed it in 
31bd5e9c12023b793a7ef30d6d14f2290698ffc1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to