nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r586741670
##########
File path: r/configure
##########
@@ -145,7 +150,7 @@ else
# TODO: what about non-bundled deps?
BUNDLED_LIBS=`cd $LIB_DIR && ls *.a`
BUNDLED_LIBS=`echo $BUNDLED_LIBS | sed -E "s/lib(.*)\.a/-l\1/" | sed
-e "s/\\.a lib/ -l/g"`
- PKG_LIBS="-L$(pwd)/$LIB_DIR $PKG_LIBS $BUNDLED_LIBS"
+ PKG_DIRS="-L$(pwd)/$LIB_DIR $PKG_DIRS"
Review comment:
Yeah, I followed that. I just meant that I don't think it's possible for
`PKG_DIRS` to be set to anything other than "" before here, so you don't need
to append it do you, just set `PKG_DIRS="-L$(pwd)/$LIB_DIR"`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
