nealrichardson commented on a change in pull request #9610:
URL: https://github.com/apache/arrow/pull/9610#discussion_r586743366
##########
File path: r/configure
##########
@@ -182,15 +187,33 @@ if [ $? -eq 0 ] || [ "$UNAME" = "Darwin" ]; then
# Always build with arrow on macOS
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_ARROW"
# Check for features
- LIB_DIR=`echo $PKG_LIBS | sed -e 's/ -l.*//' | sed -e 's/^-L//'`
- grep 'set(ARROW_S3 "ON")' $LIB_DIR/cmake/arrow/ArrowOptions.cmake >/dev/null
2>&1
+ LIB_DIR=`echo $PKG_DIRS | sed -e 's/^-L//'`
+ ARROW_OPTS_CMAKE="$LIB_DIR/cmake/arrow/ArrowOptions.cmake"
+ # Check for Arrow Dataset subcomponent
Review comment:
Sorry, my note was ambiguous. The order should be `-larrow_dataset
-lparquet`, correct. But if we're prepending them one at a time, we should
first prepend parquet, then arrow_dataset. If I'm following correctly, the code
here first does if ARROW_DATASET, do `PKG_LIBS="-larrow_dataset $PKG_LIBS"`,
then if ARROW_PARQUET, do `PKG_LIBS="-lparquet $PKG_LIBS"`, which would result
in `-lparquet -larrow_dataset`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
