WillAyd commented on code in PR #2260:
URL: https://github.com/apache/arrow-adbc/pull/2260#discussion_r1808853247
##########
c/validation/adbc_validation.h:
##########
@@ -491,6 +491,14 @@ class StatementTest {
const char* timezone);
};
+template <typename CType>
+void StatementTest::TestSqlIngestType(ArrowType type,
Review Comment:
> Hmm if not used by subclasses we could keep them in the CC file
Do you mean to make these free-standing functions in the module? I think the
challenge there is that they ultimately wrap `TestSqlIngestType`, which relies
on some of the class members
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
