lidavidm commented on code in PR #2260:
URL: https://github.com/apache/arrow-adbc/pull/2260#discussion_r1809697131
##########
c/validation/adbc_validation.h:
##########
@@ -491,6 +491,14 @@ class StatementTest {
const char* timezone);
};
+template <typename CType>
+void StatementTest::TestSqlIngestType(ArrowType type,
Review Comment:
I mean that private methods would be fine but ideally we can keep the body
in the CC file and not in the header? Or is that not doable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
