WillAyd commented on code in PR #2260:
URL: https://github.com/apache/arrow-adbc/pull/2260#discussion_r1809702867


##########
c/validation/adbc_validation.h:
##########
@@ -491,6 +491,14 @@ class StatementTest {
                                             const char* timezone);
 };
 
+template <typename CType>
+void StatementTest::TestSqlIngestType(ArrowType type,

Review Comment:
   If you are talking about TestSqlIngestType we can move this back to the cc 
file if we explicitly instantiate the template types that subclasses can use 
there as well. 
   
   The other methods already have their implementations in the cc module 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to