WillAyd commented on code in PR #2260:
URL: https://github.com/apache/arrow-adbc/pull/2260#discussion_r1806958399
##########
c/validation/adbc_validation.h:
##########
@@ -491,6 +491,14 @@ class StatementTest {
const char* timezone);
};
+template <typename CType>
+void StatementTest::TestSqlIngestType(ArrowType type,
Review Comment:
There's also `TestSqlIngestNumericType` and `TestSqlIngestTemporalType` that
would be affected by the same issue, although these aren't actually used by any
subclasses.
Maybe these should be private methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
