paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2007924014
##########
cpp/src/parquet/metadata.cc:
##########
@@ -309,6 +321,14 @@ class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
descr_->sort_order());
}
+ inline bool is_geo_stats_set() const {
+ if (possible_geo_stats_ == nullptr &&
+ column_metadata_->__isset.geospatial_statistics) {
+ possible_geo_stats_ = MakeColumnGeometryStats(*column_metadata_, descr_);
Review Comment:
I don't really mind either way, but the `Statistics` are currently
initialized in exactly the same way:
```c
if (possible_stats_ == nullptr) {
possible_stats_ = MakeColumnStats(*column_metadata_, descr_);
}
```
...and so even if I update this there is still no thread safety for the
`ColumnChunkMetadata`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
