paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2007953070
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -1088,6 +1114,10 @@ Status ToParquetSchema(const ::arrow::Schema*
arrow_schema,
const WriterProperties& properties,
const ArrowWriterProperties& arrow_properties,
std::shared_ptr<SchemaDescriptor>* out) {
+ // TODO(paleolimbot): I'm wondering if this geo_crs_context is reused when
testing
+ // on MINGW, where we get some failures indicating non-empty metadata where
it was
+ // expected
+ arrow_properties.geo_crs_context()->Clear();
Review Comment:
I had to add this because a number of tests reused the `arrow_properties`
(sometimes) so I had to clear this before each walk of the schema. I agree this
is weird (which is one of the reasons I removed the `GeoCrsContext`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
