paleolimbot commented on code in PR #45459: URL: https://github.com/apache/arrow/pull/45459#discussion_r2007967892
########## cpp/src/parquet/arrow/writer.cc: ########## @@ -546,6 +554,10 @@ Status GetSchemaMetadata(const ::arrow::Schema& schema, ::arrow::MemoryPool* poo std::string schema_as_string = serialized->ToString(); std::string schema_base64 = ::arrow::util::base64_encode(schema_as_string); result->Append(kArrowSchemaKey, std::move(schema_base64)); + + // Add any required fields collected by the GeoCrsContext + properties.geo_crs_context()->AddProjjsonCrsFieldsToFileMetadata(result.get()); Review Comment: Agreed! (I removed the GeoCrsContext for now and perhaps a dedicated change could weigh better options for doing this, or perhaps writers will find the workaround of putting `projjson:xxx` and adding the `xxx` to the their own field metadata sufficient). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
