paleolimbot commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2007965479
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -428,13 +447,19 @@ Status FieldToNode(const std::string& name, const
std::shared_ptr<Field>& field,
}
case ArrowTypeId::EXTENSION: {
auto ext_type =
std::static_pointer_cast<::arrow::ExtensionType>(field->type());
- // Built-in JSON extension is handled differently.
+ // Built-in JSON extension and GeoArrow are handled differently.
Review Comment:
Yes, particularly with https://github.com/apache/arrow/pull/45866 it's
apparent that there is some common code among extension types that could
perhaps be separated (and with variant we'll be up to four extension types
to/from five parquet types). I could try that here but I wonder if it would
easier to review in a dedicated change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
