WillAyd commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044767032
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
Yes Meson wants you to specify a minimum version. In more recent releases,
it will throw deprecation warnings if you do not do this:
https://mesonbuild.com/Release-notes-for-1-6-0.html#default-to-printing-deprecations-when-no-minimum-version-is-specified
As far as 1.3.0 is concerned, I just started with that as baseline from
other projects like arrow-nanoarrow, numpy, etc...If there is a need for older
versions, we can definitely analyze how far back we want to go and reassess
what features may need to be tweaked
With that said, what is preventing you downstream from just using build
isolation when installing or building the package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
