mgorny commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044848777
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
It would. It would also prevent me from using a new enough meson if it
happens to be installed for a different Python version than the one the package
is being built for, because then the .dist-info wouldn't be detected.
As I've said regarding CMake, the usual way of dealing with this is to
enforce the dependency via `get_requires_for_build_wheel`. To be honest, I'm
somewhat surprised `meson-python` doesn't do that already — they seem to have
correct logic for `ninja` and `patchelf`, but for some reason insist on listing
`meson` as a Python dependency rather than an external dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
