mgorny commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044804389
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
But that document talks about setting a minimum version in `meson.build` and
not `pyproject.toml`. We don't use build isolation because our purpose is to
use system packages that 1) have been verified with regards to supply chain
security, 2) have been tested and marked stable (rather than using whichever
newest version PyPI offers), 3) may include downstream patches if necessary at
the point.
Just to be clear, I'm not against requiring `>=1.3.0`. I'm against enforcing
an artificial Python-level dependency on a package that is used as an external
program.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
