mgorny commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2044645547
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
Review Comment:
Why do you need to add a dependency on CMake? Such a dependency is
particularly problematic for downstreams, given that regular CMake
installations don't provide a `cmake` Python distribution, and following the
`build-system.requires` here implies having a non-distribution prebuilt CMake
version installed and overriding the correct CMake executable.
If such a dependency is really required, then it should be added via
`get_requires_for_build_wheel()` hook if system CMake executable is not
provided, much like `scikit-build-core` does.
##########
python/pyproject.toml:
##########
@@ -17,19 +17,21 @@
[build-system]
requires = [
+ "cmake < 4",
"cython >= 3",
# Starting with NumPy 1.25, NumPy is (by default) as far back compatible
# as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
# define). For older Python versions (where NumPy 1.25 is not yet
available)
# continue using oldest-support-numpy.
"oldest-supported-numpy>=0.14; python_version<'3.9'",
"numpy>=1.25; python_version>='3.9'",
+ "meson>=1.3.0",
Review Comment:
Is this necessary to enforce a minimum meson version? Again, this is a
problematic dependency for downstreams. To the best of my knowledge,
`meson-python` calls `meson` as an external executable, and we do strongly
prefer that package builds used our downstream version of `meson` rather than
installing another one for the purpose of building pyarrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
