if0ne commented on PR #3714: URL: https://github.com/apache/arrow-adbc/pull/3714#issuecomment-3534085655
> Once the code in `blocking` is moved back to the current location I can give another review. > > @lidavidm do we really need everything to be a `Future`, even get/set options? I made the `AsyncOptionable` because in the DataFusion implementation, setting options involved asynchronous operations. It might be possible to make `get_option_*` sync, but I would keep `set_option` async. https://github.com/if0ne/arrow-adbc/blob/61963f8e450926da1657f31112db9498f789b380/rust/driver/datafusion/src/lib.rs#L247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
